shift-org/shift-docs

Change API response when requesting an invalid event ID

开放

#566 创建于 2024年1月24日

 (1 条评论) (0 个反应) (1 位负责人)JavaScript (24 个派生)auto 404
APIbackendgood first issue

仓库指标

星标
 (28 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Currently, if you request a single event by ID (e.g. /events.php?id=99999) and the ID is non-existent or the event was deleted, we return a 200 OK response with an empty array. This is essentially a "not found" response, but in a roundabout way. We should just return a proper 404 response.

(But we should continue to return an empty array for day range requests that don't have any events scheduled. An empty array is meaningful in that scenario.)

贡献者指南