${HYPERFINE_ITERATION} is not visible in prepare or conclude commands · sharkdp/hyperfine#781

(4 评论) (0 反应) (0 负责人)Rust (28,110 star) (479 fork)batch import

feature-requestgood first issue

描述

I thought I could use the ${HYPERFINE_ITERATION} env variable that is exposed (mentioned as a solution in https://github.com/sharkdp/hyperfine/issues/778) ; however this is only accessible in the main command of the iteration, not the prepare or conclude steps for each iteration.

So for example if I want to prepare , test and cleanup a series of files, I would do something like this (with echo for illustrative purposes) :

 ~/hyperfine --runs 5 --prepare 'echo touch file${HYPERFINE_ITERATION}.dat' \
                  'echo testing file${HYPERFINE_ITERATION}.dat' \
                  --conclude 'echo rm file${HYPERFINE_ITERATION}.dat' --show-output

However this does not work because the env var is not exposed in all the steps:

Benchmark 1: echo testing file${HYPERFINE_ITERATION}.dat
touch file.dat
testing file0.dat
rm file.dat
touch file.dat
testing file1.dat
rm file.dat
touch file.dat
testing file2.dat
rm file.dat
touch file.dat
testing file3.dat
rm file.dat
touch file.dat
testing file4.dat
rm file.dat
  Time (mean ± σ):      90.7 µs ± 202.8 µs    [User: 116.6 µs, System: 252.7 µs]
  Range (min … max):     0.0 µs … 453.5 µs    5 runs

so it's not possible to prepare and clean up each file.

贡献者指南

技术栈: rust
领域: cli
议题类型: feature
难度: 3
预计时间: 1-3 hours
活动状态: fresh
清晰度: clear
前置要求: Rust basicsFamiliarity with hyperfine's codebaseUnderstanding of environment variables
新手友好度: 70
研究方向: To add HYPERFINE ITERATION to prepare and conclude commands, locate where the environment variables are set for the main command (likely in src/benchmark.rs). The prepare and conclude commands are likely spawned in the same loop. Ensure the iteration number is exported to those subprocesses. Check linked issue #778 for existing discussion on the env var. After making changes, test with the provided example.