sharkdp/fd

Design and refactoring / general code quality

Open

#382 创建于 2019年1月4日

在 GitHub 查看
 (15 评论) (1 反应) (0 负责人)Rust (42,984 star) (1,059 fork)batch import
good first issuehelp wanted

描述

This is intended as a tracking issue for general code quality and design discussions. @sharkdp feel free to close this when you think quality has reached an overall satisfactory level.

To start, I'll quote a recent comment by @sharkdp from a discussion on a PR thread:

There are many things I have in mind that would hopefully help to improve the code quality:

  • Group related functions into impl blocks of appropriate structs such that we don't have to pass around so many parameters.
  • Think about a unified interface for filters (file type, file size, modification data, file extension, ..). Maybe a trait-based interface where the filters would be stored in a Vec<Box<dyn Filter>>.
  • Extract some of the functionality like the OsStr-based path handling into separate libraries / crates.

贡献者指南

技术栈
rust
领域
clideveloper experience
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
over 1 week
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
unclear
前置要求
Rust
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
15
研究方向
This is a meta issue for general code quality improvements in the fd repository. It references a PR discussion (#309) and suggests grouping related functions into struct impl blocks, creating a trait based filter interface, and extracting OsStr path handling into separate crates. No concrete task is defined, so a newcomer should first identify a specific code quality issue, perhaps by browsing the codebase for areas lacking modularity or documentation, and propose a focused refactoring. The maintainer (@sharkdp) has noted that this issue can be closed when quality is satisfactory, so further input from the community may be needed to define actionable subtasks.