serverless/serverless

`serverless package` should not attempt to follow symlinks in excluded directories

Open

#6,890 创建于 2019年10月26日

在 GitHub 查看
 (6 评论) (1 反应) (0 负责人)JavaScript (46,915 star) (5,734 fork)batch import
cat/packagingenhancementhelp wanted

描述

Reproduce by creating a serverless.yml with the following included:

package:
  exclude:
    - example/

And then creating an example/ dir and a broken symlink inside it, eg. mkdir example/; ln -s /does/not/exist example/broken.

Running serverless package on this will cause an ENOENT error.

  Error: ENOENT: no such file or directory, open '/home/adys/src/_/web/scripts/broken_symlink'
      at Package.getFileContent (/home/adys/.local/share/yarn/global/node_modules/serverless/lib/plugins/package/lib/zipService.js:134:15)
      at Package.getFileContentAndStat (/home/adys/.local/share/yarn/global/node_modules/serverless/lib/plugins/package/lib/zipService.js:123:12)
      at Array.map (<anonymous>)
      at WriteStream.<anonymous> (/home/adys/.local/share/yarn/global/node_modules/serverless/lib/plugins/package/lib/zipService.js:92:46)
      at WriteStream.emit (events.js:210:5)
      at WriteStream.EventEmitter.emit (domain.js:476:20)
      at /home/adys/.local/share/yarn/global/node_modules/serverless/node_modules/graceful-fs/graceful-fs.js:231:14
      at /home/adys/.local/share/yarn/global/node_modules/serverless/node_modules/graceful-fs/graceful-fs.js:258:16
      at FSReqCallback.oncomplete (fs.js:146:23)

贡献者指南

技术栈
javascriptnodejs
领域
backendclouddevops
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic Node.js file systemUnderstanding of symlinks
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The bug is in the packaging logic at `lib/plugins/package/lib/zipService.js`, specifically in the `getFileContent` and `getFileContentAndStat` methods (lines around 123-134). The issue is that when iterating over files to include in the package, symlinks inside excluded directories are still being followed, causing ENOENT errors for broken symlinks. The fix should ensure that files inside excluded directories are skipped before any attempt to read their content. Review the directory exclusion logic and the file traversal loop to add a check that skips files whose path starts with any excluded directory. Also check the existing tests for packaging to add a test case for this scenario.