segment-boneyard/nightmare

refactor: win.webContents.executeJavaScript(src) to use promises

Open

#1,387 创建于 2018年2月28日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (19,507 star) (1,076 fork)batch import
3.xHelp Wantedenhancement

描述

This should allow us to remove the javascript.js and enable context isolation for better security.

docs: https://electronjs.org/docs/api/web-contents#contentsexecutejavascriptcode-usergesture-callback

贡献者指南

技术栈
javascriptnodejs
领域
tooling
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic Electron knowledgepromises in JavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue asks to refactor `win.webContents.executeJavaScript(src)` to use promises instead of callbacks, which would allow removing the `javascript.js` file. The documentation link provided (https://electronjs.org/docs/api/web contents#contentsexecutejavascriptcode usergesture callback) shows the current callback based API. A newcomer should examine the `javascript.js` file in the repository to understand its current usage and then implement the promise based version, ensuring context isolation is enabled.