schickling/chromeless

Ability to change image type and quality on screenshot

Open

#256 创建于 2017年8月21日

在 GitHub 查看
 (0 评论) (8 反应) (0 负责人)TypeScript (13,240 star) (606 fork)batch import
APIfeaturehelp wanted

描述

I wanted to use jpeg to capture screenshots with lower quality so I can render the screenshots much faster (which has typically been the case when using other tools like phantomJS).

The current API doesn't have support for these customization when generating a screenshot. Capture screenshot method supports image format and quality (as well as some other options): https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-captureScreenshot

It would be great if the chromeless API had support for this. Seems like PDF options are already supported and is just a passthrough to the CDT: https://github.com/graphcool/chromeless/blob/master/src/api.ts#L234

Would be great to expose something similar for captureScreenshot

Thanks!

贡献者指南

技术栈
typescriptnodejs
领域
testingtooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScriptNode.jschromeless APIChrome DevTools Protocol
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Examine src/api.ts line 234 for the PDF passthrough pattern and implement similar parameter forwarding for the captureScreenshot method. Refer to the Chrome DevTools Protocol documentation for captureScreenshot parameters. Ensure new options are correctly typed and passed to the underlying CDP call.