schickling/chromeless

Pass chromePath and chromeFlags in Chromeless options to chrome-launcher

Open

#184 创建于 2017年8月6日

在 GitHub 查看
 (0 评论) (4 反应) (0 负责人)TypeScript (13,240 star) (606 fork)batch import
APIfeaturehelp wanted

描述

Add chromePath and chromeFlags to ChromelessOptions which get passed to the chrome-launcher's constructor so that users can specify a path to their Chrome installation and provide custom flags.

Brought up in https://github.com/graphcool/chromeless/issues/158#issuecomment-320455862

贡献者指南

技术栈
typescriptnodejs
领域
testingbackend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic TypeScript knowledgeFamiliarity with chrome launcher
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The issue requests adding `chromePath` and `chromeFlags` to `ChromelessOptions` and passing them to the `chrome launcher` constructor. Look at the current `ChromelessOptions` type definition (likely in `src/index.ts` or similar) and the section where `chrome launcher` is instantiated (e.g., `src/chromeless.ts`). Check the referenced issue #158 for context. Implement by extending the options interface and modifying the `chrome launcher` call to pass the new properties. Ensure TypeScript types are updated accordingly.