scalameta/metals

Clean constructor parameters for `Indexer` and `ScalaCli`

Open

#4,788 创建于 2023年1月1日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Scala (2,300 star) (421 fork)batch import
good first issueimprovementtech debt

描述

Another follow up after https://github.com/scalameta/metals/pull/4776.

There's need to pass every constructor argument as a function in scala.meta.internal.metals.Indexer and scala.meta.internals.ScalaCli

  • Usually, replacing () =>, should be straighforward change, but sometimes () => was used to capture mutable state.
  • probably Indexerand ScalaCli aren't the only ones which can be refactored. Person doing this task can browse other classes (optional)

贡献者指南

技术栈
scala
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Scala programmingFamiliarity with Metals internalsUnderstanding of mutable state patterns
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the constructor parameters of Indexer and ScalaCli classes in scala.meta.internal.metals package. Identify which () => parameters can be replaced with direct values and which are capturing mutable state. For the latter, ensure the refactoring preserves correctness. Optionally, extend the refactoring to other similar classes in the codebase.