sass/dart-sass

Legacy JS API does not handle symlinks properly

Open

#1,687 创建于 2022年5月4日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)Dart (4,192 star) (376 fork)batch import
bughelp wanted

描述

this is with npm sass .

relative import fails when it starts with 2 dots @import ../some-style.

I also checked how fs.existsSync handles paths with .. in it. on linux fs.existsSync fails to find the file if the path contains .., on windows it works...

贡献者指南

技术栈
javascriptnodejs
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
Node.js filesystem basicssymlink concept
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The bug is in the legacy JS API of dart sass where relative imports with '..' fail on Linux due to symlink handling. Investigate how fs.existsSync and related functions handle paths with '..' on Linux vs Windows. Look at the JS API source (likely in lib/src/legacy.js or similar) to understand the import resolution logic. Check if there are any existing tests for symlink behavior. The fix may involve using realpath or fs.realpathSync to resolve symlinks before checking file existence.
Legacy JS API does not handle symlinks properly · sass/dart-sass#1687 | Good First Issue