sandstorm-io/sandstorm

GitHub authentication doesn't set the correct primary email

Open

#3,665 创建于 2022年9月24日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (6,583 star) (737 fork)batch import
buggood first issueshell

描述

Filing this for tracking right now, it's gotta be a Meteor accounts package issue, and I want to track it down. I have my original Gmail account and my actual email account both in GitHub, because many commits used my old Gmail address, but my GitHub account has the correct primary set, and only the primary is allowed for notifications and such.

However, when I log into a new Sandstorm instance with GitHub, my old Gmail account is also pulled in, and ends up set as the notification/primary address, which means my notifications are lost to the ether (or a Google account I check maybe every other month or so).

贡献者指南

技术栈
javascriptnodejs
领域
authenticationbackend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
Meteor accounts packageGitHub OAuthEmail handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the Meteor accounts github package to see how it retrieves and sets the primary email. Compare the GitHub API response for the user's emails with the logic in the package. Check the user model to ensure the correct email is stored as primary. Look for any configuration in the Sandstorm codebase that might override the email selection.