sandstorm-io/sandstorm

Demo tests in `tests/basic.js` are broken.

Open

#3,615 创建于 2022年4月10日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (6,583 star) (737 fork)batch import
good first issuesandstorm-dev

描述

I noticed when picking through the test suite there is logic to explicitly disable demo related tests in tests/basic.js, apparently because at some point they were blocking release and considered not critical.

We should actually fix those eventually.

贡献者指南

技术栈
javascript
领域
testing
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with tests/basic.jsAbility to reproduce test failures
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Start by examining tests/basic.js to identify which demo tests are disabled and the logic that disables them. Run the test suite to observe the failures. Look at the git history for any previous attempts or discussions. Then propose a plan to fix the failing demo tests.