sampotts/plyr

Muting doesn't work for Vimeo videos in Chrome.

Open

#1,084 创建于 2018年7月3日

在 GitHub 查看
 (5 评论) (4 反应) (0 负责人)JavaScript (25,318 star) (2,856 fork)batch import
BugHelp Wanted

描述

Expected behaviour

To be able to add the muted: true property to the Plyr constructor and the video to be muted.

Actual behaviour

Video plays with sounds in Chrome.

  • Browser: Chrome
  • Version: 67.0.3396.99
  • Operating System: MacOS
  • Version: 10.13.3

Steps to reproduce

Create a div with provider set to vimeo and pass through the vimeo video id with data-plyr-embed-id. Instantiate the video with var hero_video = new Plyr('#hero_player_plyr', { autoplay: true, muted: true, volume: 0, controls: [] });

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptPlyr library understanding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The issue is that the `muted` property is not being applied to Vimeo videos in Chrome. Investigate the Vimeo provider implementation in Plyr (likely `src/js/providers/vimeo.js`). Check how the `muted` option is passed to the Vimeo embed API. Compare with the HTML5 provider where muting works. Also review the existing comments for additional insights. A potential fix might involve setting the `muted` attribute on the Vimeo iframe or adjusting the Vimeo player parameters.
Muting doesn't work for Vimeo videos in Chrome. · sampotts/plyr#1084 | Good First Issue