saadpasta/developerFolio

Images in Dark mode look weird

Open

#484 创建于 2022年4月5日

在 GitHub 查看
 (12 评论) (0 反应) (0 负责人)JavaScript (4,696 star) (2,351 fork)batch import
good first issuehacktoberfest

描述

When in light mode, all the images which have dark blue shade, like the computer desk or the Dart image looks fine, but in dark mode they aren't visible as they use dark colors and don't dynamically become white or change to a light shade when the website is switched to dark mode. Probably there should be 2 set of images and they need to be toggled with light and dark toggle.

贡献者指南

技术栈
javascriptreactcsshtml
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic JavaScriptCSS for dark modeImage handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the current dark mode implementation in the repository (likely using CSS media query or JavaScript toggle). Review comments on issue #484 for any suggested approaches. Identify images that are problematic (e.g., computer desk, Dart image). Consider creating lighter versions of those images and implementing a toggle mechanism that switches between light and dark image sources based on the current theme. Look at how other images are handled in the codebase for consistency.