rwf2/Rocket

Allow wildcards in content-type

Open

#583 创建于 2018年3月11日

在 GitHub 查看
 (6 评论) (5 反应) (0 负责人)Rust (25,738 star) (1,645 fork)batch import
enhancementgood first issue

描述

Currently (Rocket version 0.4.0-dev) if you use a wildcard in content-type you will get a warning like this:

warning: 'image/*' is not a known media type
 --> src/handlers/image.rs:5:33
  |
5 | #[post("/image", format = "image/*", data = "<data>")]
  |                                 ^^^^^^^^^

Using wildcard e.g. for images is needed as you do not know what the actual type of the image will be (png, gif, jpg etc.) and you want to handle all of them in the same route.

贡献者指南

技术栈
rust
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust programmingRocket framework basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate how Rocket currently parses and validates media types in the 'format' route attribute. The warning originates from a media type parser that rejects wildcards. Look at the 'rocket codegen' crate's 'format' parsing logic and the 'http' crate's 'MediaType' implementation. Consider proposing a change to allow wildcards by accepting known top level types (e.g., 'image') with any subtype. Check issue comments for prior discussion and any maintainer suggestions.