rust-lang/this-week-in-rust

Email publishing codegen script is not formatting correctly

Open

#3,591 创建于 2022年8月26日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)HTML (1,932 star) (1,010 fork)batch import
bughelp wanted

描述

The Pelican publishing script used by the Makefile command optimize-email is not picking up TWIR_NEWSLETTER_THEME setting and defaulting to a CSS style that does not match our most recent issues (e.g. 454).

Currently, the workaround for this has been to change pelicanconf.py from:

if '1' == os.environ.get('TWIR_NEWSLETTER_THEME'):
    THEME = 'themes/newsletter'
else:
    THEME = 'themes/rusted'

to:

THEME = 'themes/newsletter'

贡献者指南

技术栈
pythonhtmlcssshell
领域
content
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue is in the This Week in Rust repository, specifically in pelicanconf.py where the environment variable TWIR NEWSLETTER THEME is checked. The fix involves ensuring the script correctly picks up the theme setting when generating the email. The current workaround of directly setting the theme to 'themes/newsletter' suggests a simple code change to read the environment variable properly and apply the correct theme. No linked PRs or maintainer questions were found.