Enhance diff_check with more unicode et al · rust-lang/rustfmt#5884

(13 评论) (2 反应) (1 负责人)Rust (4,893 star) (760 fork)batch import

E-help-wantedgood first issue

描述

Follow up action item from a topic I raised in https://github.com/rust-lang/rustfmt/pull/5864#issuecomment-1676425492 relative to adding some additional test repos to improve our coverage of string formatting with various characters and encodings.

One suggested repo to include is https://github.com/unicode-org/icu4x as well as some from https://github.com/unicode-rs

I opted to simply mention icu4x as part of this instead of directly adding it because I noticed that repo is using cargo make and I didn't have bandwidth to determine if that'd cause any issues/require any additional changes to our script.

New repos can be wired up by adding a call site with respective args here:

https://github.com/rust-lang/rustfmt/blob/b069aac44ddfdb70d55d9ae40695be44515e5bb0/ci/check_diff.sh#L170-L192

贡献者指南

技术栈: rustshell
领域: devopstestingci cd
议题类型: test
难度: 2
预计时间: 1-3 hours
活动状态: blocked
清晰度: clear
前置要求: shell scripting basicsfamiliarity with rustfmt
新手友好度: 60
研究方向: Review the linked PR comment (#5864) for context. Add a new call to the icu4x repository in ci/check diff.sh around lines 170-192, following the existing pattern. Test the script locally to ensure compatibility with cargo make used by icu4x.