PreferSameLine brace_style with trailing_comma Vertical produces weird results · rust-lang/rustfmt#2321 | Good First Issue

(3 评论) (0 反应) (1 负责人)Rust (760 fork)batch import

I-poor-formattinggood first issueonly-with-option

仓库指标

Star: (4,893 star)
PR 合并指标: (平均合并 67天) (30 天内合并 5 个 PR)

描述

Upgrading rustfmt-nightly from 0.2.15 to 0.3.4 created this change:

@@ -104,8 +122,7 @@ impl FetchCommandMessages {
 
 pub trait FetchBuilderMessages
 where
-    Self: Sized,
-{
+    Self: Sized, {
     fn prepare(self) -> FetchCommandMessages;
 
     fn num(self, num: u32) -> FetchCommandMessages {

This seems like a bug, since trailing_comma = "Vertical" should not trigger if the opening brace is on the same line.

贡献者指南

研究方向: 检查 rustfmt 源代码中关于 brace style 和 trailing comma 的格式化逻辑，特别是当 brace style 设置为 PreferSameLine 时它们的交互方式。
技术栈: rust
领域: tooling
议题类型: 缺陷
难度: 2
预计时间: 1-3 小时
活动状态: 活跃
清晰度: 清晰
前置要求: GitRust
新手友好度: 60