rust-lang/rustfmt

PreferSameLine brace_style with trailing_comma Vertical produces weird results

Open

#2,321 创建于 2017年12月30日

在 GitHub 查看
 (3 评论) (0 反应) (1 负责人)Rust (4,893 star) (760 fork)batch import
I-poor-formattinggood first issueonly-with-option

描述

Upgrading rustfmt-nightly from 0.2.15 to 0.3.4 created this change:

@@ -104,8 +122,7 @@ impl FetchCommandMessages {
 
 pub trait FetchBuilderMessages
 where
-    Self: Sized,
-{
+    Self: Sized, {
     fn prepare(self) -> FetchCommandMessages;
 
     fn num(self, num: u32) -> FetchCommandMessages {

This seems like a bug, since trailing_comma = "Vertical" should not trigger if the opening brace is on the same line.

贡献者指南

技术栈
rust
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust programmingunderstanding of rustfmt configuration options
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the interaction between `brace style = "PreferSameLine"` and `trailing comma = "Vertical"` in rustfmt. The bug shows that when the opening brace is on the same line as the trait declaration, a trailing comma is incorrectly added. Examine the source code for formatting traits and functions, likely in files related to brace placement and trailing comma logic. Check if the assignee (gentoid) has any progress or comments on the issue.