rust-lang/rust-clippy

New lint: Use `Into`/`TryInto` in bounds as opposed to `From`/`TryFrom`

Open

#4,894 创建于 2019年12月10日

在 GitHub 查看
 (29 评论) (1 反应) (0 负责人)Rust (10,406 star) (1,391 fork)batch import
A-lintL-stylegood first issue

描述

When writing generic bounds such as:

fn foo<T>(a: T) where u32: From<T>;

Into should be preferred, like this:

fn foo<T>(a: T) where T: Into<u32>;

Why the former is bad: Into is a superset of From. In some cases coherence rules prevent implementing From but do allow implementing Into. As a result Into is more generic bound than From.

Category: Style, I guess?

贡献者指南

技术栈
rust
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic RustUnderstanding of trait boundsClippy development setup
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Study the Clippy developer guide for adding a new lint. Look at existing lints that suggest trait usage, such as the 'trait usage' lints in clippy lints/src/. The issue comments may contain further rationale; review them for consensus on exact implementation. The lint should detect generic bounds like `u32: From<T>` and suggest replacing with `T: Into<u32>`. Explore the clippy lints crate to understand naming conventions and testing patterns.