rust-lang/rust-clippy

Suggestion: borrowing a RefCell in funarg position

Open

#4,632 创建于 2019年10月4日

在 GitHub 查看
 (2 评论) (3 反应) (0 负责人)Rust (10,406 star) (1,391 fork)batch import
A-lintT-middlegood first issue

描述

I recently came across this fun correctness bug in my code: https://github.com/rust-lang/rust/issues/65086.

I’m not sure how I could have known this without asking a compiler developer. Can we add a lint prohibiting RefCell borrows in funarg position since they prevent mutable borrows further down the stack?

贡献者指南

技术栈
rust
领域
developer experiencetooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
RustBorrow checker basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
This feature requests a new Clippy lint to detect RefCell borrows in function argument positions. To implement, study existing Clippy lints related to borrows (e.g., borrow deref ref). The lint will need to analyze function call expressions in the HIR or MIR, checking if any argument is a borrow from a RefCell. Also review the linked Rust issue (https://github.com/rust lang/rust/issues/65086) for understanding the problem. The implementation should produce a warning with a clear message explaining why the pattern is problematic.