rust-lang/rust-clippy

Extract commonly used visitors to utils

Open

#4,413 创建于 2019年8月19日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)Rust (10,406 star) (1,391 fork)batch import
C-enhancementgood first issue

描述

Both #3427 and #4386 implement a Visitor that walks an expression and searches for a return. This should be de-duplicated.

Maybe there are other Visitors in the Clippy code base, that also do similar things and can be extracted to utils.

Originally posted by @mikerite in https://github.com/rust-lang/rust-clippy/pull/4386#issuecomment-522407926

贡献者指南

技术栈
rust
领域
tooling
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
RustClippy internalsVisitor pattern
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Examine the linked PRs #3427 and #4386 to understand the duplicated Visitor implementations. Search the Clippy source code (likely in `clippy lints/src/`) for similar Visitors that traverse expressions and check for returns. Extract the common logic into a utility module, perhaps `clippy utils/src/visitors.rs`. Refer to issue comments for further details on which visitors to consolidate.
Extract commonly used visitors to utils · rust-lang/rust-clippy#4413 | Good First Issue