rust-lang/rust-clippy

False positive for boxed local with `wasm_bindgen`

Open

#4,351 创建于 2019年8月7日

在 GitHub 查看
 (14 评论) (0 反应) (0 负责人)Rust (10,406 star) (1,391 fork)batch import
C-bugI-false-positivegood first issue

描述

wasm_bindgen is a little bit different than the issue that's been resolved with traits. In particular, wasm_bindgen just generates code around the non-trait implemented function, and the only way to use native JS arrays as parameters is to use Box<[...]>.

In general, I think maybe boxed slices should be considered ok for local parameters, as they're conceptually very similar to vectors.

贡献者指南

技术栈
rust
领域
developer experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Rustclippy internalswasm bindgen
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the clippy lint for boxed local parameters (likely in clippy lints/src/boxed.rs or similar). Understand how wasm bindgen generates code and why boxed slices are treated as local parameters. Check existing tests for boxed lints and add a test case with wasm bindgen to reproduce the false positive. Consider if the lint should allow boxed slices for wasm bindgen functions or if a more general fix is needed.