rust-lang/rust-clippy

Lint suggesting from_fn instead of while let Some(x)

Open

#3,940 创建于 2019年4月11日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Rust (10,406 star) (1,391 fork)batch import
A-lintL-styleL-suggestiongood first issue

描述

With the release of 1.34 with the from_fn function, I'd like to propose a new lint that matches: while let Some(x) = expr and suggests replacing it with for x in from_fn(|| expr). (With a special-case for while let Some(x) = fn() that suggests for x in from_fn(fn) if possible.)

贡献者指南

技术栈
rust
领域
tooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust programmingclippy contributing guide
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine existing clippy lints in the clippy lints crate to understand the structure for adding a new lint. The pattern to match is `while let Some(x) = expr` where `expr` is a function call. Refer to the std::iter::from fn documentation and clippy's developer guide for adding lints.
Lint suggesting from_fn instead of while let Some(x) · rust-lang/rust-clippy#3940 | Good First Issue