rust-lang/rust-clippy

Add utils helper for filtering out type/lifetime parameters on generics

Open

#3,787 创建于 2019年2月19日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Rust (10,406 star) (1,391 fork)batch import
C-enhancementgood first issue

描述

See https://github.com/rust-lang/rust-clippy/pull/3786/files , we have a lot of code that does something like params.args.iter().filter_map(|arg| match arg { GenericArg::Lifetime(lt) => Some(lt), _ => None }

We should probably have a helper function that returns an iterator for these, placed in utils. Probably something like:

fn types_of_generics(generics: &Generics) -> impl Iterator<Type> {...}
fn lifetimes_of_generics(generics: &Generics) -> impl Iterator<Lifetime> {...}

贡献者指南

技术栈
rust
领域
developer experiencetooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust genericsIterator patternClippy codebase structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue references a previous PR (https://github.com/rust lang/rust clippy/pull/3786) that contains similar code. The proposed helper functions should be placed in the `utils` module. Review existing iterator patterns in Clippy's source, particularly how `GenericArg` variants are filtered. The functions should return `impl Iterator<Type>` and `impl Iterator<Lifetime>`. No current assignees or linked PRs.
Add utils helper for filtering out type/lifetime parameters on generics · rust-lang/rust-clippy#3787 | Good First Issue