rust-lang/rust-clippy

Politely mention that `Box<&T>` is almost the most useless type you can have

Open

#2,394 创建于 2018年1月23日

在 GitHub 查看
 (25 评论) (21 反应) (1 负责人)Rust (10,406 star) (1,391 fork)batch import
A-lintT-middlegood first issue

描述

Found in the wild: https://stackoverflow.com/questions/48406077/mutation-of-a-variable-inside-while-loop

List of types that make no sense that we should be linting about:

  • Box<&T>
  • Box::new(SomeT) where sizeof::<T>() <= sizeof::<usize>()
    • unless there are Box::into_raw calls within the function
  • Rc<Box<T>>
  • Rc<Rc<T>>
  • Rc<&T>
  • more...?

贡献者指南

技术栈
rust
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust programmingClippy lintingType system basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Examine the clippy lint infrastructure in `clippy lints/src/`. Look at existing lints like `box vec` or `rc buffer` for patterns. Investigate how to detect generic type arguments and type sizes using Rust's type system. The issue has an assignee (whirm), so coordinate with them before starting work.
Politely mention that `Box<&T>` is almost the most useless type you can have · rust-lang/rust-clippy#2394 | Good First Issue