rust-lang/rust-clippy

New lint: clone on arguments taken by reference

Open

#2,074 创建于 2017年9月19日

在 GitHub 查看
 (7 评论) (0 反应) (1 负责人)Rust (10,406 star) (1,391 fork)batch import
A-lintL-unnecessaryT-middlegood first issue

描述

If a function takes an argument by reference, but later calls .clone() on it (or otherwise requires an impl Clone or impl Copy from it), lint that taking it by ownership allows the caller to pass in its memory rather than forcing a clone on the data.

I don't know if this is possible, but can it default to allow on public functions and deny on crate-private functions (due to the API change)?

贡献者指南

技术栈
rust
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust programmingclippy internalsRust ownership model
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
To implement this lint, the contributor should first understand clippy's lint infrastructure by examining existing lints in the `clippy lints` crate. They should look at how other lints detect patterns in function signatures and bodies. The issue's comment thread may provide additional clarification. The functionality should detect functions that accept a reference and later call `.clone()` on it, and suggest changing to ownership. The distinction between public and crate private functions should be considered, possibly using the `is in unconfigured public` or similar attribute.