rust-lang/rust-clippy

Lint request: Prevent lifetimes that are only used for function output

Open

#1,874 创建于 2017年7月5日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)Rust (10,406 star) (1,391 fork)batch import
A-lintL-correctnessS-needs-discussionT-middlegood first issue

描述

The following:

fn lifetime<'a>() -> &'a str {
    "Why some people do that"
}

Can be more clearly written as this. Also, using 'static lifetime makes it clear that it was intended, especially in unsafe code where returning unbound lifetime may as well be a mistake.

fn lifetime() -> &'static str {
    "Why some people do that"
}

贡献者指南

技术栈
rust
领域
developer experiencetooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Rust language basicsUnderstanding of lifetimesFamiliarity with clippy's lint creation process
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The issue suggests a new lint to detect lifetimes that are only used in function outputs. Start by examining existing clippy lints related to lifetimes (e.g., in clippy lints/src/lifetimes.rs). Understand how clippy registers and implements lints. Look at the discussion in the issue comments for any additional constraints or alternatives. Consider the diagnostic output and potential false positives. Note that this is a feature request with no assignee, so it is available for contribution.