rust-lang/rust-clippy

Extensions to should_assert_eq

Open

#1,810 创建于 2017年6月3日

在 GitHub 查看
 (1 评论) (1 反应) (1 负责人)Rust (10,406 star) (1,391 fork)batch import
C-enhancementgood first issue

描述

I found this in the standard library:

assert!(o == owned && b == borrowed)

This should be a case for should_assert_eq. Additionally, it might be nice to have a lint that suggests splitting asserts with && to multiple assert statements, for better debugging.

贡献者指南

技术栈
rust
领域
toolingdeveloper experiencetesting
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Rust programmingFamiliarity with clippy's lint systemBasic understanding of should assert eq
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the current implementation of should assert eq in clippy, likely in the 'clippy lints' crate. The issue suggests modifying the lint to handle the pattern `assert!(o == owned && b == borrowed)` and possibly creating a new lint to split `&&` in assertions. Look at existing test files and the lint's documentation. Check if there are any previous attempts or related PRs by searching the issue tracker. The assignee may have left comments or a branch.
Extensions to should_assert_eq · rust-lang/rust-clippy#1810 | Good First Issue