Two suggestions for more DRY code · rust-lang/rust-clippy#1674

(3 评论) (0 反应) (0 负责人)Rust (10,406 star) (1,391 fork)batch import

A-lintL-styleT-middlegood first issue

描述

Given this code:

struct Foo { cap: usize }
impl Foo {
    fn new() -> Foo { Foo { cap: 1 } }
    fn with_capacity(cap: usize) -> Foo {
        Foo { cap: cap }
    }
}
fn main() {}

In my opinion Clippy should suggest to replace four of those usages of "Foo" with "Self" and to remove one ": cap", making the code more DRY, the intended resulting code should be:

struct Foo { cap: usize }
impl Foo {
    fn new() -> Self { Self { cap: 1 } }
    fn with_capacity(cap: usize) -> Self {
        Self { cap }
    }
}
fn main() {}

贡献者指南

技术栈: rust
领域: tooling
议题类型: feature
难度: 3
预计时间: half day
活动状态: stale
清晰度: clear
前置要求: Rust programmingClippy lint frameworkAST knowledge
新手友好度: 65
研究方向: Look at existing Clippy lints that suggest using `Self` like `use self`. Examine the `clippy lints` directory for how lints are structured. Check issue comments for any additional context. The lint should trigger when a struct name is repeated in an impl block where `Self` would suffice.