rust-lang/rust-clippy

Rewrite `arithmetic_side_effects` to not use matching on string representation of types

Open

#16,359 创建于 2026年1月8日

在 GitHub 查看
 (1 评论) (1 反应) (1 负责人)Rust (10,406 star) (1,391 fork)batch import
C-enhancementgood first issue

描述

Description

arithmetic_side_effects uses the string representation of types to compare them. This will miss aliases (including core/alloc → std), takes longer to compare, etc.

It should use a method similar to what is done in the disallowed_types lint, where maps of DefId or PrimTy are built at lint initialization time and then used throughout the tree walk. Some type lookup code could probably even be shared (including the part where unloaded crates don't cause errors).

Version

Additional Labels

No response

贡献者指南

技术栈
rust
领域
developer experiencetooling
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
RustClippy internalsDefId and PrimTyLint initialization
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Study the implementation of the `disallowed types` lint in the clippy codebase to understand how maps of DefId or PrimTy are built at initialization. Look at files like `clippy lints/src/disallowed types.rs` and the associated type lookup code. The goal is to replicate that pattern in `arithmetic side effects` located in `clippy lints/src/arithmetic side effects.rs`. Ensure that the new approach handles type aliases and avoids string representation comparisons.
Rewrite `arithmetic_side_effects` to not use matching on string representation of types · rust-lang/rust-clippy#16359 | Good First Issue