rust-lang/rust-clippy

Lint functions taking references as arguments but only use them to create an owned value

Open

#1,563 创建于 2017年2月21日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Rust (10,406 star) (1,391 fork)batch import
A-lintE-hardL-unnecessaryT-middlegood first issue

描述

A function that takes a &str and always converts it to a String, should be taking a String argument instead. This is hard to generalize, but we could start with anything implementing to_owned and only calling to_owned.

贡献者指南

技术栈
rust
领域
tooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Rust knowledgefamiliarity with Clippy lint implementation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
This issue proposes a new lint for Clippy that checks functions taking a reference (like `&str`) but only using it to create an owned value (like `to owned()`). To implement, examine existing lints in the `clippy lints` crate, particularly those in `src/clippy lints/` that deal with function arguments and type checking. Look at the lint 'needless pass by value' as a reference. The current issue lacks a specific implementation strategy; a good starting point is to discuss the lint's scope and possible false positives with maintainers before coding.
Lint functions taking references as arguments but only use them to create an owned value · rust-lang/rust-clippy#1563 | Good First Issue