rust-lang/rust-clippy

`std_wildcard_imports` to lint against `use std::mod::*`

Open

#13,961 创建于 2025年1月7日

在 GitHub 查看
 (4 评论) (1 反应) (1 负责人)Rust (10,406 star) (1,391 fork)batch import
A-lintE-help-wantedgood first issue

描述

What it does

This is a version of wildcard_imports that affects only imports from the standard crates std, core, proc_macro, alloc, and test.

Advantage

wildcard_imports is in pedantic, which seems reasonable for most crates. However, using glob imports from the standard library means that upgrading Rust version can break the build. Recent examples:

I am proposing std_wildcard_imports as a separate lint from wildcard_imports so it can get enabled by default, likely in clippy::style (or possibly uplifted https://github.com/rust-lang/rust/issues/135672#issuecomment-2605426121)

Drawbacks

Confusion between wildcard_imports and std_wildcard_imports, noise on existing code, sometimes use proc_macro::* or similar is fine for testing.

Example

Lint on glob imports:

use std::mem::*; // error
use core::sync::*; // error
use proc_macro::*; // error

However, using glob imports from prelude modules should not raise this warning:

use std::io::prelude::*; // ok
use std::prelude::rust_2021:* // unlikely, but still ok

Non-std crates don't raise this lint

use regex::*; // ok

贡献者指南

技术栈
rust
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
RustClippy lint internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue is assigned to alanbondarun. To implement, study existing lints like wildcard imports in clippy lints/src. Follow the pattern: add a new lint module, register it, and write tests. The lint should detect glob imports from std, core, proc macro, alloc, and test, but exclude prelude modules. See linked issues for rationale.