rust-lang/rust-clippy

useless op on lhs of integer division or modulo

Open

#1,324 创建于 2016年11月7日

在 GitHub 查看
 (2 评论) (0 反应) (1 负责人)Rust (1,391 fork)batch import
A-lintL-correctnessL-unnecessaryT-middlegood first issue

仓库指标

Star
 (10,406 star)
PR 合并指标
 (平均合并 19天 22小时) (30 天内合并 113 个 PR)

描述

(x + n + y) % n or (x + n + y) / n can simply be replaced by (x + y) % n or (x + y) / n + 1

this isn't true for the following computations on unsigned integers:

(x + n - y) % n or (x + n - y) / n

as they might go negative due to the subtraction. For explicitly evading INT_MAX issues, this lint will cause false positives, but that could be evaded by not linting if INT_MAX is mentioned somewhere near the operation.

most likely, whenever this lint triggers, it is a bug in the equation, so the suggestion doesn't fix the underlying issue, but it will raise awareness of it.

贡献者指南