rust-lang/rust-clippy

Add lints against more manual integer ops where direct methods exist

Open

#12,894 创建于 2024年6月6日

在 GitHub 查看
 (6 评论) (1 反应) (1 负责人)Rust (1,391 fork)batch import
A-lintgood first issue

仓库指标

Star
 (10,406 star)
PR 合并指标
 (平均合并 18天 15小时) (30 天内合并 115 个 PR)

描述

What it does

Checks for more manual reimplementations of various integer operations that are available as methods. (This can, and probably should, be separated into different lints.)

An existing lint of this type is manual_rem_euclid, preferring rem_euclid over ((a % b) + b) % b.

(We can also add midpoint as replacement for the overflow-incorrect (a + b) / 2, once that's stabilized.)

Advantage

  • Implementations in the standard library are often better optimized, such as using intrinsics or unchecked operations internally.
  • Edge cases like overflows may not be handled by the manual implementations properly, leading to panics in debug builds.
  • This can simplify code that may otherwise look hacky.

Drawbacks

  • Some code may be directly translated from, e.g. old C code. Changing them to method calls may harm readability.
  • The replacements are sometimes longer than the original.
  • Some edge case properties might be intended, not accidental.
  • There simply are too many poor man's implementations of intrinsics. We will need to prioritize common cases.

Example

let [a, b, c]: [u32; 3] = bar();
let div = (a + (b - 1)) / b;
if a > 0 { foo(a - 1) }
if b >= c { foo(b - c) }
if a != 0 { foo(b / a) }
if a != 0 { foo(a.ilog2()) }

let single_bit_v1: bool = a.count_ones() == 1;
let single_bit_v2: bool = a & (a - 1) == 0;
let log = 31 - a.leading_zeros();
let logs = (a.ilog(2), a.ilog(10));
let count = (!a).count_ones();
let rot = (a << 2) | (a >> 30);

Could be written as:

let [a, b, c]: [u32; 3] = bar();
let div = a.div_ceil(b);
if let Some(quo) = b.checked_div(a) { foo(quo) }
if let Some(decr) = a.checked_sub(1) { foo(decr) }
if let Some(diff) = b.checked_sub(c) { foo(diff) }
if let Some(log) = a.checked_ilog2() { foo(log) }

let single_bit_v1 = a.is_power_of_two();
let single_bit_v2 = a.is_power_of_two();
let log = a.ilog2();
let logs = (a.ilog2(), a.ilog10());
let count = a.count_zeros();
let rot = a.rotate_left(2);

贡献者指南