rust-lang/rust-clippy

Lint to warn about str::as_ptr() usage in ffi call

Open

#1,236 创建于 2016年9月19日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Rust (10,406 star) (1,391 fork)batch import
A-lintL-correctnessT-middlegood first issue

描述

Hello. It would be nice to have a warning when using str::as_ptr() in a ffi call instead of using CStr.

For instance, in the following code:

unsafe { printf("Hello".as_ptr() as *const _) };

should give a warning and propose something like:

let cstring = CString::new("Hello".as_bytes()).unwrap();
unsafe { printf(cstring.as_ptr()) };

Thanks to add this lint.

贡献者指南

技术栈
rust
领域
developer experiencetooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
familiarity with Rust FFIclippy lint creation basicsunderstanding of CStr
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine existing clippy lints that target function calls (e.g., the 'fn to numeric cast' lint) to understand the pattern matching on function arguments. Follow the clippy development guide at https://github.com/rust lang/rust clippy/blob/master/CONTRIBUTING.md to set up the environment and add a new lint. The lint should detect calls to `str::as ptr()` where the result is passed to an extern function; consider using `fn has item` or checking the function call's parameter types.