rust-lang/rust-analyzer

Expression lowering uses unreasonable amount of stack space

Open

#5,317 创建于 2020年7月11日

在 GitHub 查看
 (3 评论) (0 反应) (1 负责人)Rust (14,924 star) (1,726 fork)batch import
A-perfC-enhancementE-hardS-actionablefungood first issue

描述

Our lowering code for expressions is a single giant match, and looks like it consumes a lot of stack space, even in release mode.

See https://github.com/rust-analyzer/rust-analyzer/pull/5316/commits/12d52a726a1e6ca0f6b08343d13d0f6b50d94d8c for some ways to observe this.

It would be nice to optimize this!

贡献者指南

技术栈
rust
领域
performancetooling
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
5
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Rust programmingcompiler internalsexpression lowering
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
10
研究方向
Investigate the expression lowering code in the rust analyzer repository, specifically the giant match statement that consumes excessive stack space. Review the referenced commit (12d52a7) in PR #5316 for methods to observe stack usage. Consider splitting the match into separate functions or using boxed closures to reduce stack depth. Look for any existing comments or discussion on the issue for additional context.