matching_brace function not correct when jumping from open brace to close brace · rust-lang/rust-analyzer#1942

(8 评论) (0 反应) (0 负责人)Rust (14,924 star) (1,726 fork)batch import

E-has-instructionsE-mediumS-actionablegood first issue

描述

swap the order of do_check parameters the makes the test case failed

do_check("struct Foo <|>{ a: i32, }", "struct Foo { a: i32, }<|>");

this matching behavior should be symmetrical

if the matching node is a left brace, we use start(), if the matching node is a right brace, we should use end()

技术栈: rust
领域: developer experiencetooling
议题类型: bug
难度: 2
预计时间: under 1 hour
活动状态: stale
清晰度: clear
前置要求: Rustrust analyzer codebase
新手友好度: 80
研究方向: The bug is in crates/ra ide api/src/matching brace.rs. The function do check currently uses start() for left brace but should use end() for right brace to ensure symmetry. The fix involves swapping the parameter order in the test case and adjusting the check for right brace to use end(). No linked PRs or maintainer questions; the issue is self contained.