rtk-ai/rtk

cargo clippy: -- separator not preserved when cargo flags are present

Open

#660 创建于 2026年3月17日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)Rust (48,085 star) (2,914 fork)batch import
bugeffort-smallfilter-qualitygood first issue

描述

Summary

rtk cargo clippy drops or mishandles the -- separator when any cargo flag is passed before it. Arguments intended for clippy lints (e.g., -D warnings) are instead passed as filenames to rustc, causing compilation errors.

Reproduction

# Create a minimal project
cargo init /tmp/rtk-repro && cd /tmp/rtk-repro

# Works: no flags before --
rtk cargo clippy -- -D warnings
# ✓ cargo clippy: No issues found

# Fails: any flag before -- breaks it
rtk cargo clippy --all-targets -- -D warnings
# error: multiple input filenames provided (first two filenames are `src/main.rs` and `-D`)

# Direct cargo works fine with the same flags
cargo clippy --all-targets -- -D warnings
# (no errors)

Failing variations

All of these fail with the same multiple input filenames error:

rtk cargo clippy --all-targets -- -D warnings
rtk cargo clippy --workspace -- -D warnings
rtk cargo clippy -p repro -- -D warnings
rtk cargo clippy --all-targets --all-features -- -D warnings -A clippy::needless_update

Passing variation

Only the bare form (no cargo flags before --) works:

rtk cargo clippy -- -D warnings    # OK

Expected behavior

rtk cargo clippy <cargo-flags> -- <clippy-flags> should behave identically to cargo clippy <cargo-flags> -- <clippy-flags>. The -- separator and everything after it should be passed through to clippy unchanged.

Environment

  • rtk 0.30.0
  • macOS (Darwin 25.3.0, aarch64)
  • rustc 1.94.0

贡献者指南

技术栈
rust
领域
clideveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic Rust knowledgeunderstanding of CLI argument separationfamiliarity with cargo and clippy
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The bug is in argument parsing for the 'cargo clippy' subcommand. Look at the CargoClippy implementation in the codebase (likely under src/commands/cargo.rs or similar) where the command line is constructed. The issue is that cargo flags before ' ' are not being properly separated from clippy flags after ' '. Investigate how the raw arguments are split and passed to the cargo subprocess. There may be a missing check for the ' ' separator when additional cargo flags (like all targets) are present. Check for any existing logic that handles ' ' and see if it is short circuited when cargo flags are added. The fix should ensure that if ' ' is encountered, everything after it is passed unchanged to clippy.
cargo clippy: -- separator not preserved when cargo flags are present · rtk-ai/rtk#660 | Good First Issue