rtk-ai/rtk

Add rust-version to Cargo.toml (MSRV = 1.91)

已关闭

#1,402 创建于 2026年4月19日

在 GitHub 查看贡献者指南
 (1 条评论) (0 个反应) (0 位负责人)Rust (2,914 个派生)batch import
area:cieffort-smallenhancementgood first issuepriority:low

仓库指标

星标
 (48,085 个星标)
PR 合并指标
 (平均合并 11天 1小时) (30 天内合并 45 个 PR)

描述

v0.37.1 uses str::floor_char_boundary() in src/cmds/system/pipe_cmd.rs:135, which was stabilized in Rust 1.91.0.

Without rust-version in Cargo.toml, building with Rust < 1.91 fails with a confusing error:

error[E0658]: use of unstable library feature `round_char_boundary`
 --> src/cmds/system/pipe_cmd.rs:135:21
  |
135 | let end = input.floor_char_boundary(end);
    |                 ^^^^^^^^^^^^^^^^^^^

Adding rust-version = "1.91" to [package] in Cargo.toml would give a clear error message at build time instead:

error: package `rtk v0.37.1` cannot be built because it requires rustc 1.91 or newer

This affects distribution packagers (e.g., Arch Linux AUR) where the system Rust version may lag behind.

贡献者指南

研究方向
The issue requests adding a `rust version` field to `Cargo.toml` in the `[package]` section. The value should be `"1.91"` because the code uses `str::floor char boundary()` which was stabilized in Rust 1.91.0 and is used in `src/cmds/system/pipe cmd.rs:135`. This change will provide a clear error message for users with older Rust versions. No additional code changes are needed.
技术栈
rust
领域
build system
议题类型
功能
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1 小时以内
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
新近可参与
清晰度议题是否清楚说明期望改动、验收标准和下一步。
清晰
前置要求
Rust development environmentKnowledge of Cargo.toml
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
95