rtfeldman/seamless-immutable

Does not work with Javascript Maps

Open

#171 创建于 2016年11月14日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)JavaScript (5,367 star) (221 fork)batch import
enhancementhelp wanted

描述

I am using a javacript map to store data I retrieve from an api for a udacity project.

However, the data is not being saved to the immutable object.

here is a branch you can clone and verify:

  1. clone https://github.com/noahehall/udacity-trainschedule/tree/serviceworkers
  2. npm install
  3. npm run start

here is picture of implementation

here is picture of error received from immutable error TypeError: immutableDoesNotWorkWithJavascriptMaps.data.has is not a function(…)

Is there a workaround to get immutable to use Javascript maps? am i doing something wrong (very likely...)? or should I abandon seamless immutable?

贡献者指南

技术栈
javascript
领域
data
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaScriptMap objectimmutable data concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue requests support for JavaScript Map objects in seamless immutable. Currently, the library only handles plain objects and arrays. To implement, examine the immutable wrapper pattern for objects (e.g., overriding get, set, etc.) and adapt it for Map. The user provided a reproduction branch (https://github.com/noahehall/udacity trainschedule/tree/serviceworkers). Review comments for any maintained guidance. The fix would involve creating an ImmutableMap class that mirrors the API but uses Map's internal storage.