rstudio/shiny

Printing within Chrome causes href to be displayed on download button

Open

#2,447 创建于 2019年5月24日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)R (5,649 star) (1,890 fork)batch import
Effort: LowHelp WantedPriority: LowType: Bug :bug:

描述

System details

Browser Version: Chrome (only one tested)

Example application or steps to reproduce the problem

Screen Shot 2019-05-24 at 2 37 31 PM

Describe the problem in detail

Community post: https://community.rstudio.com/t/download-button-appears-with-session-information-when-printing-paper/30873

Known fix: https://stackoverflow.com/questions/7301989/need-to-remove-href-values-when-printing-in-chrome

@media print {
  a[href]:after {
    content: none !important;
  }
}

贡献者指南

技术栈
rcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic CSS
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
95
研究方向
The fix is a CSS media query to hide href content in print mode. Locate the Shiny package's CSS file (likely shiny/www/shared/shiny.css) and add `@media print { a[href]:after { content: none !important; } }`. Confirm that the fix resolves the issue by printing a Shiny app with download buttons.