rstudio/plumber

@filter cors for DELETE

Open

#409 创建于 2019年4月3日

在 GitHub 查看
 (4 评论) (2 反应) (0 负责人)R (1,437 star) (257 fork)batch import
difficulty: noviceeffort: mediumhelp wanted

描述

The filter mentioned in #143 works for GET requests, but is not active for DELETE. When I convert my DELETE to a (misnomed) GET, everything is fine.

#* @filter cors
cors <- function(res) {
  res$setHeader("Access-Control-Allow-Origin", "*")
  plumber::forward()
}

贡献者指南

技术栈
无
领域
backendapi
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
R programmingplumber basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The issue reports that the @filter cors only applies to GET requests but not DELETE. To fix, examine the filter registration in plumber's source code, likely in the plumber package's R/filter.R or similar. Look for where the @filter handler is attached to routes; it may need to be applied to all HTTP methods (or at least DELETE). Check if there is a conditional based on request method, and extend to include DELETE. Also verify with a test that DELETE requests receive the CORS headers.