rsmbl/Resemble.js

Feature request: separate colors for errors in image 1 and 2

Open

#198 创建于 2020年4月19日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (4,364 star) (433 fork)batch import
Feature requestGood first issue

描述

I'm using resemble via the wdio-image-comparison-service. It works great, but I would love to be able to specify that the erroneous pixels present in image 1 (my baseline) are green (expected) while the errors from image 2 (the comparison) are red. Hopefully that makes sense. Basically I want it to display like a git diff.

贡献者指南

技术栈
javascript
领域
testing
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with JavaScriptBasic understanding of image comparison libraries
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Examine the Resemble.js source code, particularly the output rendering logic in 'resemble.js'. Look for where error pixels are colored, likely in the `compareImages` or `createImageData` functions. The feature request is to add an option for users to specify separate colors for baseline and comparison errors (like a git diff). Check if any existing PRs or forks address this. Since there are no linked issues or PRs, the implementation would involve modifying the output color mapping to accept two color strings instead of one, and applying them to the respective image differences.
Feature request: separate colors for errors in image 1 and 2 · rsmbl/Resemble.js#198 | Good First Issue