rkt/rkt

rkt fetch does not include port when discovering

Open

#365 创建于 2015年1月12日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Go (8,871 star) (865 fork)batch import
help wantedpriority/Pmaybereviewed/duplicate

描述

Issuing a fetch with the rkt tool drops the port:

./rkt fetch 10.0.2.2:5000/my/repository
Get http://10.0.2.2?ac-discovery=1: dial tcp 10.0.2.2:80: i/o timeout

As seen above, the URL that was loaded does not have the port given.

贡献者指南

技术栈
go
领域
backendinfrastructure
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programming basicsUnderstanding of HTTP URL construction
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the code that constructs the ac discovery URL in the fetch command, likely in the store or discovery package. The bug is that the port from the argument is dropped when building the URL. Look for URL building functions that may not include the port. A good starting point is the 'rkt fetch' command handler and related helpers.