We should include golint checks into our CI tests.
Implement checks, output findings as warnings
Fix all warnings
Error out on findings
贡献者指南
技术栈
go
领域
ci cdtooling
议题类型
devops
难度面向新贡献者的预计实现难度,1 表示很小改动,5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度:新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
GoCI/CD basicsGit
新手友好度1-100 的估计分数,表示该议题对首次贡献者的友好程度。
70
研究方向
The issue requests adding golint checks to the CI pipeline. Examine the repository's CI configuration files (e.g., .travis.yml, appveyor.yml, or Makefile) to determine where to add a lint step. First, ensure the project's Go code can be linted with golint. Then, add a job that runs golint and outputs warnings, followed by fixing current warnings, and finally making the lint step fail on errors. Consult the project's contributing guidelines and existing CI scripts for integration patterns.
CI does not do run golint (or equivalent) checks · rkt/rkt#1901 | Good First Issue