rkt/rkt

build: Allow to blacklist some functional tests

Open

#1,553 创建于 2015年10月7日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Go (8,871 star) (865 fork)batch import
area/developer toolingarea/testinghelp wantedpriority/Pmaybe

描述

Currently we have a GO_TEST_FUNC_ARGS variable which is passed directly to go test. With that we can do something like make check GO_TEST_FUNC_ARGS='-run "TestAuth.*"' to run only TestAuth{Sanity,Basic,Oauth,Override,Ignore} tests.

But it is a hassle to run all tests but TestFetch for example. An idea would be to maybe deprecate the GO_TEST_FUNC_ARGS in favor of GO_TEST_RUN_REGEXP and GO_TEST_DONT_RUN_REGEXP.

To run only TestAuth tests the invocation would be make check GO_TEST_RUN_REGEXP='TestAuth.*'.

To run all the tests but TestFetch: make check GO_TEST_DONT_RUN_REGEXP='TestFetch'.

To run all the auth test but override: make check GO_TEST_RUN_REGEXP='TestAuth.*' GO_TEST_DONT_RUN_REGEXP='TestAuthOverride' (or '.*Override').

Some other (probably bit crazy) notes:

  • I couldn't find any builtin command to list all the tests that would be executed, so a hacky way to get the list would be:
    • git grep -P 'func Test\w+\(\w+\s+\*testing\.T\)' tests | grep -o '\bTest[[:alnum:]]\+' | sort -u
  • run grep '$(GO_TEST_RUN_REGEXP)' on that list to get a whitelist
  • run `grep -v '$(GO_TEST_DONT_RUN_REGEXP)' on that whitelist to get a final list of tests to run
  • prepare the final list to something like (test1)|(test2)|...|(testN)
  • We could then run `go test -run '$(prepared_final_list)' github.com/coreos/rkt/tests

贡献者指南

技术栈
go
领域
build systemtesting
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Go testingFamiliarity with Makefile variables
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue requests adding two environment variables, GO TEST RUN REGEXP and GO TEST DONT RUN REGEXP, to allow filtering which tests to run. The implementation would involve modifying the Makefile to read these variables and pass them as run arguments to go test. The logic should handle combining both regexps to produce a final list of test names. Look at the existing GO TEST FUNC ARGS variable in the Makefile for reference. The suggestion includes a method to list all tests using git grep, which could be implemented as a helper script. No existing PRs or maintainer comments provide further direction.
build: Allow to blacklist some functional tests · rkt/rkt#1553 | Good First Issue