rizinorg/cutter

Comments window should show unescaped comments whenever possible

Open

#2,961 创建于 2022年6月7日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C++ (14,852 star) (1,123 fork)batch import
good first issue

描述

See the comment at 0x1400022c6 address, it's a Chinese words 好的, which are shown in the disassembly but neither in Cutter nor in the Rizin's CCl output:

image

Originally posted by @XVilka in https://github.com/rizinorg/cutter/issues/2960#issuecomment-1148768300

贡献者指南

技术栈
cpp
领域
desktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++Qt frameworkUnicode encoding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the Comments window implementation in Cutter (likely in src/gui/CommentsWidget.cpp or similar). Check how comments are fetched from Rizin and displayed via Qt's QString. The issue suggests that unescaped Unicode characters are not displayed; perhaps the string is being escaped before display. Look at the 'CCl' output of Rizin and compare with raw comment data. Ensure that the text is treated as UTF 8 and not as ASCII. Consider using QTextCodec or QString::fromUtf8. Refer to the linked issue #2960 for context.