rizinorg/cutter

Cutter GUI trimms shell code to whole bytes (might discard last nibble)

Open

#2,831 创建于 2021年11月22日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C++ (14,852 star) (1,123 fork)batch import
good first issue

描述

Environment information

  • Operating System: linuxmint 20.2
  • Cutter version: 2.0.3
  • File format: any
  • Arch: N/A
  • Type: N/A

Describe the bug Cutter open shell code gui trimms shell code to whole bytes (might discard 1 nibble)

To Reproduce Steps to reproduce the behavior:

  1. Launch Cutter
  2. Enter odd number of nibbles
  3. Click ok
  4. See information loss

Expected behavior

  1. Fill the last lonely nibble with a 0-nibble so no information is discarded.
  2. When no shell code is entered proceed with empty input OR grey out the OK-button.

Screenshots image

贡献者指南

技术栈
cpp
领域
desktopsecurity
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Investigate the shell code input handling in Cutter's GUI code, likely in files related to dialogs or shellcode entry (e.g., `src/dialogs/ShellcodeDialog.cpp` or similar). The bug is that odd nibble counts are truncated; expected behavior is to pad with a zero nibble. Look for string to bytes conversion logic and add padding. The issue is well described and localized, making it suitable for a first time contributor.
Cutter GUI trimms shell code to whole bytes (might discard last nibble) · rizinorg/cutter#2831 | Good First Issue