rigor789/vue-scrollto

v-scroll-to breaks HTML5 form validation with Enter

Open

#155 创建于 2019年9月9日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (1,966 star) (114 fork)batch import
help wanted

描述

Problem

If a HTML form has a button with v-scroll-to, that breaks form validation which occurs when a user presses Enter.

Steps to reproduce

  1. Open jsfiddle at https://jsfiddle.net/semenov/ukt84qvy/7/
  2. Type something in input 1, press Enter. The form validation for input 2 will NOT kick in, instead the page will be scrolled to a seemingly random (?) location:
  1. Edit jsfiddle, remove v-scroll-to, re-run it.
  2. Type something in input 1, press Enter. The form validation for input 2 WILL kick in, and the page will be scrolled to show input 2:

Expected behavior

Regardless of v-scroll-to, pressing Enter in a form scrolls to the input element that doesn't pass validation.

贡献者指南

技术栈
javascriptvue
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Vue.js basicsHTML form events
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue is that the v scroll to directive intercepts the Enter key press event, preventing the form's default validation behavior. Investigate the directive's event handler in the source code (likely in src/index.js or similar). The fix should ensure that the directive only triggers scrolling when the click event comes from a button/input not in a form submission context, or delegate to the form's submit event. The jSFiddle provides a minimal reproduction.
v-scroll-to breaks HTML5 form validation with Enter · rigor789/vue-scrollto#155 | Good First Issue