rev087/ng-inspector

Replacing scope object with primitive does not update correctly

Open

#138 创建于 2015年9月23日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (787 star) (100 fork)batch import
bughelp wanted

描述

(Here's a minimal example Plunkr.)

When a scope object is replaced with another object, the inspector version is replaced immediately and correctly. However, when an object is replaced with a primitive, some components still reference the old object:

  • If the property drop-down is open, the only visible change is the type icon. Otherwise in all ways, the inspector shows the old object. screen shot 2015-09-23 at 3 21 55 pm
  • If the property drop-down is closed, the primitive value is shown, however the property count is still visible, and the drop-down can be opened, leading to the above case.
  • In both situations, clicking the name or value will print the old object to the console.

贡献者指南

技术栈
javascripthtmlcss
领域
frontenddeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
AngularJS basicsbrowser extension development
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the inspector's scope watch mechanism in the source code. Look for how the inspector updates when scope values change, specifically when transitioning from object to primitive. The Plunkr example can be used to reproduce. Check if there is a missing check for primitive values in the update logic.
Replacing scope object with primitive does not update correctly · rev087/ng-inspector#138 | Good First Issue