restify/node-restify

serveStatic is non-intuitive

Open

#535 创建于 2014年2月18日

在 GitHub 查看
 (33 评论) (0 反应) (0 负责人)JavaScript (10,695 star) (983 fork)batch import
BugHelp WantedServe

描述

KISS: Keep it simple stupid. Please make it this for static files plugins, all people have the same problem, in my ofice 5 persons give me the same as bug!!

if you assign this:

server.get(/\/docs\/public\/?.*/, restify.serveStatic({
  directory: './public'
}));

will mean that if you get the url "domain.com/docs/public" this will be load the content of "public" folder. END. Not at prefix for the entire route path... and your fairy tales... Kiss men, kiss...

贡献者指南

技术栈
javascriptnodejsrest api
领域
backendapideveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic understanding of Node.jsFamiliarity with Restify frameworkStatic file serving concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Review the discussion in issue #535 about the non intuitive behavior of serveStatic. Examine the current implementation of serveStatic in the repository (likely in lib/plugins/static.js). The main request is to simplify the static file serving so that the directory argument maps directly without the route path prefix. Look for any proposed solutions in the comments and consider how to change the function signature or behavior without breaking existing usage. Then implement and test the change.
serveStatic is non-intuitive · restify/node-restify#535 | Good First Issue